Add tests for notices view #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cblgh
force-pushed
the
44-notices
branch
3 times, most recently
from
bb84336 to
5001e60
Compare
cblgh
force-pushed
the
44-notices
branch
2 times, most recently
from
9290782 to
67d6c40
Compare
cblgh
force-pushed
the
44-notices
branch
3 times, most recently
from
f184ab0 to
ebe051c
Compare
cblgh
commented
Mar 11, 2021
cblgh
force-pushed
the
44-notices
branch
2 times, most recently
from
63b0365 to
7d6d992
Compare
cryptix
requested changes
Mar 16, 2021
* webasserts.InputsInForm now also takes a Tag as arg
Co-authored-by: Henry <[email protected]>
|
i think this is ok to merge @cryptix :) |
|
ahhhhhhhhhhhhhhhhhhh
|
|
Horray! ps: usually we delete the old branches. Not sure when we wouldn't actually. |
Merged
gotcha! thanks for the reminder, i typically forget about that and do spring cleaning on all the old branches when i come across them haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #44, adding tests for various parts of the notices functionality & view.